Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "just in time" loading of records, and add ID fields #154

Merged
merged 10 commits into from
Jun 26, 2024

Conversation

peterallenwebb
Copy link
Contributor

@peterallenwebb peterallenwebb commented Jun 25, 2024

CORE-308
CORE-309

Description

Tweaks to support an id field and support "just in time" loading of record types.

Checklist

@peterallenwebb peterallenwebb requested a review from a team as a code owner June 25, 2024 14:39
@cla-bot cla-bot bot added the cla:yes label Jun 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 64.30%. Comparing base (00fbf91) to head (16ebae8).

Files Patch % Lines
dbt_common/record.py 50.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   64.27%   64.30%   +0.02%     
==========================================
  Files          51       51              
  Lines        3191     3202      +11     
==========================================
+ Hits         2051     2059       +8     
- Misses       1140     1143       +3     
Flag Coverage Δ
unit 64.30% <50.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterallenwebb peterallenwebb changed the title Paw/id param Support "just in time" loading of records, and add ID fields Jun 25, 2024
@peterallenwebb peterallenwebb added this pull request to the merge queue Jun 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 25, 2024
@peterallenwebb peterallenwebb added this pull request to the merge queue Jun 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 25, 2024
@peterallenwebb peterallenwebb added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit dbb2308 Jun 26, 2024
18 checks passed
@peterallenwebb peterallenwebb deleted the paw/id-param branch June 26, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants